Repository navigation
fix: decode the features with the reponse charset - #477
Merged
Merged
Conversation
alexanto
force-pushed
the
fix/charset-decoding
branch
from
November 12, 2026 11:16
d786a51 to
0095a37
Compare
alexanto
force-pushed
the
fix/charset-decoding
branch
from
November 12, 2026 12:07
0095a37 to
377107f
Compare
alexanto
added a commit
that referenced
this pull request
Nov 12, 2026
* fix: decode the features with the reponse charset * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
before the custom transport feature was added, decoding was the http library's resposibility. now, we don't know what lib is used, so it was moved out and i used utf-8 by default and used
errors="replace"if we ever receive a payload with a different charset, than can be a problem because invalid features or constraints can get cached and passed to the enginethis problem was flagged by copilot in two PRs, i don't think it is sth to be worried about in real life, but better safe then sorry